feat: implement new architecture support for iOS #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated RNMParticle and RNMPRokt to support new architecture with TurboModules. - Refactored imports and method signatures to align with new architecture standards. - Introduced RoktNativeLayoutComponentView for new architecture layout handling. - Added method implementations for better compatibility with new architecture. - Updated sample app Podfile to enable new architecture by default.
There was a problem hiding this comment.
Pull Request Overview
This pull request implements React Native's new architecture support for iOS by migrating the mParticle React Native SDK from the legacy bridge to TurboModules and Fabric components.
- Enables new architecture by default in sample app and updates module configurations
- Adds new architecture-specific component views and TurboModule implementations
- Refactors method signatures to support both legacy and new architecture patterns
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| sample/ios/Podfile | Enables new architecture by setting RCT_NEW_ARCH_ENABLED to '1' |
| react-native-mparticle.podspec | Updates dependency checks and changes React dependency from 'React' to 'React-Core' |
| ios/RNMParticle/RoktNativeLayoutComponentView.mm | New Fabric component view implementation for Rokt layout handling |
| ios/RNMParticle/RoktNativeLayoutComponentView.h | Header file for the new Fabric component view |
| ios/RNMParticle/RNMParticle.m | Major refactoring with TurboModule support, method signature updates, and dual architecture compatibility |
| ios/RNMParticle/RNMParticle.h | Updates interface to support both legacy bridge and TurboModule protocols |
| ios/RNMParticle/RNMPRokt.m | Adds TurboModule support and new architecture-specific view handling |
| ios/RNMParticle/RNMPRokt.h | Updates interface declarations for new architecture compatibility |
Contributor
BrandonStalnaker
left a comment
BrandonStalnaker
left a comment
There was a problem hiding this comment.
By and large seems good. I'm a little concerned about ios/RNMParticle/RNMParticle.mm just cause with rename it was hard to pick out the changes in the code. Doubel check your imports and I think we will be good to go.
- Added new entries to .npmignore for Android and iOS build artifacts and IDE files. - Updated Xcode project configuration to include new source files and remove deprecated ones.
jamesnrokt
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing Plan
Tested with new architecture flag enabled and disabled
Master Issue
Closes https://go.mparticle.com/work/REPLACEME